Implementing string and byte[] async response handlers. Porting over … #161
Conversation
There was a problem hiding this comment.
toString was taken. I can rename it to toUtf8String and have a toString that takes a Charset though per your other suggestion.
There was a problem hiding this comment.
I must be going crazy because I can't find that this method actually exists. http://docs.oracle.com/javase/8/docs/api/?java/io/ByteArrayOutputStream.html What am I missing?
There was a problem hiding this comment.
Do we need to copyBytesFrom, or can we just use array since the output stream copies it?
There was a problem hiding this comment.
Not sure if we can assume it's backed by an array or that array constitutes the entire contents of the byte buffer.
There was a problem hiding this comment.
Yeah, I guess we would need to check if it hasArray and preserve the indices if we were to do it.
There was a problem hiding this comment.
Because this is their data, we should probably make them define the encoding.
There was a problem hiding this comment.
Does this fix all of the remaining empty-response integration test failures?
There was a problem hiding this comment.
Yeah, should fix them.
There was a problem hiding this comment.
Does this need to be varargs anymore? I only see one use. It could even be inlined?
There was a problem hiding this comment.
Nah I can inline it. Copied it from my other branch which removes some timeout handlers but didn't port that over.
There was a problem hiding this comment.
Subsriber -> Subscriber (here and elsewhere). Will the subscriber be the customer's? Could it be beneficial to log which one?
There was a problem hiding this comment.
Yes in this context it will be the customers subscriber. Were you thinking like a class name or something?
There was a problem hiding this comment.
Yeah, a class name or just calling toString on it. We could implement useful toStrings for our internal implementations?
There was a problem hiding this comment.
+1 for toString, I'll do that.
shorea
force-pushed
the
shorea-async-response-handler-string
branch
3 times, most recently
from
b4d4bb5 to
1376635
Compare
There was a problem hiding this comment.
@param charset + other javadoc changes
There was a problem hiding this comment.
It's actually the subscriber we call toString on. Since the byte subscriber didn't have any identifying state I just left it as the default implementation. I can change it to whatever though, just let me know.
shorea
force-pushed
the
shorea-async-response-handler-string
branch
from
1376635 to
bba549c
Compare
…temp fixes so PutObject will work
shorea
force-pushed
the
shorea-async-response-handler-string
branch
from
bba549c to
5ff3309
Compare
…temp fixes so PutObject will work